Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adds batch export path #8

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

adds batch export path #8

wants to merge 3 commits into from

Conversation

egbertn
Copy link

@egbertn egbertn commented Dec 26, 2019

a small addition to accounting/export

@orionstudt
Copy link
Owner

Hey man! Thanks for contributing.

I'm going to leave some notes and there's at least 1 issue I'm seeing right off the get go.

orionstudt
orionstudt requested changes Dec 30, 2019
View reviewed changes
Copy link
Owner

@orionstudt orionstudt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made my comments.. thanks again for contributing!

ModuleTypes/SubModuleChild.cs Show resolved Hide resolved
Modules/Finance/Finance.cs Outdated Show resolved Hide resolved
Modules/Finance/SubModules/AccountingBatches.cs Show resolved Hide resolved
Modules/Finance/SubModules/Export.cs Outdated Show resolved Hide resolved
Modules/Finance/SubModules/Export.cs Show resolved Hide resolved
@egbertn
Copy link
Author

egbertn commented Dec 31, 2019

Think, so ok?

@orionstudt
Copy link
Owner

Hey man, thanks for the timely update! I'll take a look at it on my end after the new year.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orionstudt orionstudt orionstudt requested changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@egbertn @orionstudt